-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rln-v2): update serde for rln-v2 #202
Conversation
Benchmark for 3b2dcb5Click to view benchmark
|
Benchmark for 3b2dcb5Click to view benchmark
|
Note: the tests will fail till we get the new artifacts from the rln-v2 ceremony |
Benchmark for c891214Click to view benchmark
|
Benchmark for c891214Click to view benchmark
|
758d853
to
2132779
Compare
Benchmark for f5f9910Click to view benchmark
|
Benchmark for 7694126Click to view benchmark
|
Benchmark for 7694126Click to view benchmark
|
Benchmark for f5f9910Click to view benchmark
|
While it's not the case, maybe we should keep the failing code at a temporary branch? |
Yes, merging into |
* feat(rln-v2): update serde for rln-v2 * fix: public tests that needed to append the new fields
* feat(rln-v2): update serde for rln-v2 (#202) * feat(rln-v2): update serde for rln-v2 * fix: public tests that needed to append the new fields * s/id_commitments/rate_commitments (#205) * feat: rename public, protocol and update tests to use rate_commitments * fix: into() * `message_id` range check (#210) * feature: range check added * fmt * feature: message_id_range_check * fix: corresponding change of types * comments: function level * fmt * fix(rln): tests (#212) * most changes * fix * fix protocol tests * fmt * ffi tests fix * feat(rln-v2): new artifacts, removed older ones (#211) * feat(rln-v2): new artifacts, removed older ones * wip: working branch * fix: remove more refs to epoch + rln_identifier * Updated serde in RLN proof verification * Updated artifacts * chore: update * chore: update * hardcoded test works * fix: proof generation and verification * fix: rln-wasm tests * fix: ffi tests * fix: rln-wasm test * fix: recover_id_secret * Fix message (#217) --------- Co-authored-by: rymnc <[email protected]> * chore: Release --------- Co-authored-by: tyshko-rostyslav <[email protected]>
In https://github.com/Rate-Limiting-Nullifier/circom-rln/blob/17f0fed7d8d19e8b127fd0b3e5295a4831193a0d/circuits/rln.circom#L8-L16 we see that there are 2 additional
private inputs,
user_message_limit
andmessage_id
, this PR adds it to the serde api's.